refactor(ext/node): consolidate node:fs (part 9)#32659
Open
bartlomieju wants to merge 6 commits intodenoland:mainfrom
Open
refactor(ext/node): consolidate node:fs (part 9)#32659bartlomieju wants to merge 6 commits intodenoland:mainfrom
bartlomieju wants to merge 6 commits intodenoland:mainfrom
Conversation
Inline `_fs_read.ts`, `_fs_readdir.ts`, `_fs_readFile.ts`, and `_fs_readlink.ts` into the main `fs.ts` module, following the same pattern as parts 1-8. Update imports in `promises.ts`, `_fs_glob.ts`, and `cp_sync.ts` to reference the consolidated location. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…nto fs.ts Inline `_fs_readFile.ts` and `_fs_readlink.ts` into the main `fs.ts` module. Skip `_fs_read.ts` and `_fs_readdir.ts` for now as they cause circular dependency issues when imported from `_fs_glob.ts` and `promises.ts`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The source snippet frame selection logic skipped `ext:` frames but not `node:` frames, causing missing source snippets for errors thrown from node: builtins after the fs consolidation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bartlomieju
commented
Mar 12, 2026
Member
Author
There was a problem hiding this comment.
This is a drive-by fix because now that code has been moved to node:fs module certain errors were changed, because they didn't match starts_with("ext:").
bartlomieju
commented
Mar 12, 2026
| [Module: null prototype] { sync_js: 1 } | ||
| [Module: null prototype] { sync_mjs: 1 } | ||
| error: Uncaught (in promise) Error: Top-level await is not allowed in synchronous evaluation | ||
| require("./async.js"); |
Member
Author
There was a problem hiding this comment.
And this is also a consequence of that change 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_fs_readFile.tsand_fs_readlink.tsinto the mainfs.tsmodulepromises.tsandcp/cp_sync.tsto reference theconsolidated location
lib.rsnode:fs(part 8) #32640)_fs_read.tsand_fs_readdir.tsfor now — they cause circulardependency issues when imported from
_fs_glob.tsandpromises.tsTest plan
cargo build --bin denopassescargo check -p deno_nodepasses🤖 Generated with Claude Code