Skip to content

fix(ext/node): remove extra properties from node:fs exports #32670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bartlomieju merged 2 commits into from
Mar 13, 2026
+0 −89
Merged

fix(ext/node): remove extra properties from node:fs exports #32670

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74a4d12
fix(ext/node): remove extra properties from node:fs exports
bartlomieju Mar 12, 2026
3ced620
fmt
bartlomieju Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 0 additions & 89 deletions ext/node/polyfills/fs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,27 +155,6 @@ const {
Uint8Array,
} = primordials;

const {
F_OK,
R_OK,
W_OK,
X_OK,
O_RDONLY,
O_WRONLY,
O_RDWR,
O_NOCTTY,
O_TRUNC,
O_APPEND,
O_DIRECTORY,
O_NOFOLLOW,
O_SYNC,
O_DSYNC,
O_SYMLINK,
O_NONBLOCK,
O_CREAT,
O_EXCL,
} = constants;

// -- stat --

import {
Expand Down Expand Up @@ -233,18 +212,6 @@ function stat(
);
}

const statPromise = promisify(stat) as (
& ((path: string | Buffer | URL) => Promise<Stats>)
& ((
path: string | Buffer | URL,
options: { bigint: false },
) => Promise<Stats>)
& ((
path: string | Buffer | URL,
options: { bigint: true },
) => Promise<BigIntStats>)
);

function statSync(path: string | Buffer | URL): Stats;
function statSync(
path: string | Buffer | URL,
Expand Down Expand Up @@ -336,11 +303,6 @@ function realpath(

realpath.native = realpath;

const realpathPromise = promisify(realpath) as (
path: string | Buffer,
options?: RealpathOptions,
) => Promise<string | Buffer>;

function realpathSync(
path: string,
options?: RealpathOptions | RealpathEncoding,
Expand Down Expand Up @@ -641,17 +603,6 @@ function statfsSync(
}
}

const statfsPromise = promisify(statfs) as (
& ((
path: string | Buffer | URL,
options?: { bigint?: false },
) => Promise<StatFs<number>>)
& ((
path: string | Buffer | URL,
options: { bigint: true },
) => Promise<StatFs<bigint>>)
);

function access(
path: string | Buffer | URL,
mode: number | CallbackWithError,
Expand Down Expand Up @@ -3036,7 +2987,6 @@ export default {
Dirent,
exists,
existsSync,
F_OK,
fchmod,
fchmodSync,
fchown,
Expand Down Expand Up @@ -3067,20 +3017,6 @@ export default {
mkdirSync,
mkdtemp,
mkdtempSync,
O_APPEND,
O_CREAT,
O_DIRECTORY,
O_DSYNC,
O_EXCL,
O_NOCTTY,
O_NOFOLLOW,
O_NONBLOCK,
O_RDONLY,
O_RDWR,
O_SYMLINK,
O_SYNC,
O_TRUNC,
O_WRONLY,
open,
openAsBlob,
openSync,
Expand All @@ -3089,7 +3025,6 @@ export default {
read,
readSync,
promises,
R_OK,
readdir,
readdirSync,
readFile,
Expand Down Expand Up @@ -3121,18 +3056,15 @@ export default {
unwatchFile,
utimes,
utimesSync,
W_OK,
watch,
watchFile,
watchPromise,
write,
writeFile,
writev,
writevSync,
writeFileSync,
WriteStream,
writeSync,
X_OK,
// For tests
_toUnixTimestamp,
};
Expand Down Expand Up @@ -3167,7 +3099,6 @@ export {
Dirent,
exists,
existsSync,
F_OK,
fchmod,
fchmodSync,
fchown,
Expand Down Expand Up @@ -3198,27 +3129,12 @@ export {
mkdirSync,
mkdtemp,
mkdtempSync,
O_APPEND,
O_CREAT,
O_DIRECTORY,
O_DSYNC,
O_EXCL,
O_NOCTTY,
O_NOFOLLOW,
O_NONBLOCK,
O_RDONLY,
O_RDWR,
O_SYMLINK,
O_SYNC,
O_TRUNC,
O_WRONLY,
open,
openAsBlob,
opendir,
opendirSync,
openSync,
promises,
R_OK,
read,
readdir,
readdirSync,
Expand All @@ -3232,7 +3148,6 @@ export {
readvPromise,
readvSync,
realpath,
realpathPromise,
realpathSync,
rename,
renameSync,
Expand All @@ -3242,9 +3157,7 @@ export {
rmSync,
stat,
statfs,
statfsPromise,
statfsSync,
statPromise,
Stats,
statSync,
symlink,
Expand All @@ -3256,7 +3169,6 @@ export {
unwatchFile,
utimes,
utimesSync,
W_OK,
watch,
watchFile,
watchPromise,
Expand All @@ -3267,5 +3179,4 @@ export {
writeSync,
writev,
writevSync,
X_OK,
};
Loading