Theme fix - #143
Merged
Merged
Conversation
kyeotic
marked this pull request as draft
February 7, 2024 23:17
kyeotic
marked this pull request as ready for review
February 8, 2024 17:38
Contributor
Author
|
@willpuckett Not sure if you are the right person to be pinging, but you appear have recent contributions. I'd love to get this fix in so I can remove my fork and go back to using this package. Anything I can do to help make that happen? |
Contributor
|
Hey I'm not associated with the project try @thisisjofrank |
Contributor
Author
|
Ok, well @thisisjofrank this is still an issue but Im going to close this PR to get it out of my PR list. I am happy to re-open it if you want to pick it up. I would love to stop maintaining a fork of this repo |
Contributor
|
This looks sensible to me! |
Contributor
|
this seems to be causing body text to be unreadable (shows as a very dark gray) in night mode on Safari on MacOS |
Contributor
|
When I switch back to previous commit, text is readable again... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #140
Use the theme state in
ColorSchemeandComponentto correctly handle browser settings. See #140 for an examplethis did not work for Firefox + Night Mode, but appears to work everywhere else.