Skip to content

fix: Wasm module should be vendored as .wasm file #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Wasm module should be vendored as .wasm file #93

wants to merge 2 commits into from

Conversation

dsherret
Copy link
Member

dsherret
dsherret commented Sep 12, 2025
View reviewed changes
rs_lib/src/local.rs

fn get_extension(url: &Url, content_type: Option<&str>) -> &'static str {
MediaType::from_specifier_and_content_type(url, content_type)
.as_ts_extension()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caused because .wasm was getting converted to .d.mts for typescript here:

https://github.com/denoland/deno_media_type/blob/abf2b6808bdff4cd6f01ec2acf51955956956792/src/lib.rs#L60

nathanwhit
nathanwhit approved these changes Sep 12, 2025
View reviewed changes
Copy link
Member

@nathanwhit nathanwhit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nathanwhit nathanwhit nathanwhit approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dsherret @nathanwhit