Skip to content

fix(compile): panic when calling op_is_terminal #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025
Merged

Conversation

JasperVanEsveld
Copy link

This works towards fixing #27730 and #21091.

An error is not handled when calling op_is_terminal.
Ironically, this causes the application to panic when bootstrapping if there is no terminal in windows.

This PR does not fully fix the issue yet, as there is a similar problem in deno's code base, see this pull request.

@CLAassistant
Copy link

CLAassistant commented Apr 10, 2025

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.96%. Comparing base (0c7f83e) to head (ec8daa5).
Report is 287 commits behind head on main.

Files with missing lines Patch % Lines
core/ops_builtin.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1116      +/-   ##
==========================================
- Coverage   81.43%   80.96%   -0.48%     
==========================================
  Files          97      101       +4     
  Lines       23877    28755    +4878     
==========================================
+ Hits        19445    23282    +3837     
- Misses       4432     5473    +1041     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@ry ry merged commit 9dae818 into denoland:main Apr 11, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants