Skip to content

Conversation

@iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Dec 13, 2025

Seems like this type is only being used in the main repo, which is being addressed in denoland/deno#31599.

@coderabbitai
Copy link

coderabbitai bot commented Dec 13, 2025

Walkthrough

A public type alias AnyError that mapped to anyhow::Error was removed from core/error.rs. The alias definition and its deprecation comment were deleted entirely. This eliminates the generic error wrapper type previously exposed at the module level. Code referencing AnyError will no longer resolve from this module, though the underlying error handling infrastructure remains intact.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing the AnyError type alias from deno_core. It's specific, concise, and clearly communicates the breaking change.
Description check ✅ Passed The description explains the rationale for the removal and references coordination with related work in the main repo. It's directly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2898ad9 and 58a11d6.

📒 Files selected for processing (1)
  • core/error.rs (0 hunks)
💤 Files with no reviewable changes (1)
  • core/error.rs

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.25%. Comparing base (0c7f83e) to head (9c8adb4).
⚠️ Report is 393 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1260      +/-   ##
==========================================
- Coverage   81.43%   80.25%   -1.19%     
==========================================
  Files          97      105       +8     
  Lines       23877    27783    +3906     
==========================================
+ Hits        19445    22298    +2853     
- Misses       4432     5485    +1053     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants