Skip to content

Conversation

@iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Dec 13, 2025

Seems to do the same job fine.

@coderabbitai
Copy link

coderabbitai bot commented Dec 13, 2025

Walkthrough

This pull request removes the custom dprint-based formatting configuration and replaces it with Deno's native formatter. The changes include deleting .dprint.json and tools/format.ts, updating the CI lint workflow to invoke deno fmt --check instead of the custom format script, and applying minor formatting adjustments to workflow files. Documentation in ops/op2/valid_args.md receives wording and formatting refinements with no functional impact.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: replacing the custom format.ts script with native deno fmt command.
Description check ✅ Passed The description is brief but related to the changeset, confirming that deno fmt performs the same formatting job as the removed tool.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
ops/op2/valid_args.md (1)

25-36: Doc additions look consistent; consider “buffer” wording for raw pointers.
For *mut u8 / *const u8 rows, “contents of the slice” reads a bit odd since these are pointers; “contents of the buffer” (or “memory”) would be slightly clearer if you want to tighten language.

Also applies to: 40-56

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2898ad9 and c3752aa.

📒 Files selected for processing (6)
  • .dprint.json (0 hunks)
  • .github/workflows/ci-job.yml (1 hunks)
  • .github/workflows/ci-lint/action.yml (1 hunks)
  • .github/workflows/ci.yml (2 hunks)
  • ops/op2/valid_args.md (1 hunks)
  • tools/format.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • .dprint.json
  • tools/format.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
  • GitHub Check: build-linux / linux test
  • GitHub Check: build-linux / linux coverage
  • GitHub Check: build-linux-arm / linux-arm lint
  • GitHub Check: build-windows / windows lint
  • GitHub Check: build-linux-arm / linux-arm test
  • GitHub Check: build-windows / windows test
  • GitHub Check: build-macos / macos lint
  • GitHub Check: build-linux / linux lint-deps
  • GitHub Check: build-linux-arm / linux-arm test-miri
  • GitHub Check: build-linux / linux test-ops
  • GitHub Check: build-linux / linux test-miri
  • GitHub Check: build-macos / macos test
🔇 Additional comments (4)
.github/workflows/ci-job.yml (1)

133-144: No functional change; indentation-only tweak is safe.
The comment stays correctly under env: and won’t affect evaluation.

.github/workflows/ci.yml (2)

6-11: Quoting the tag wildcard is a safe clarity improvement.
Avoids YAML edge-cases around * and keeps intent explicit.


26-32: Matrix expression change is formatting-only; semantics preserved.
The || fallback chain is unchanged.

.github/workflows/ci-lint/action.yml (1)

5-11: Good switch to deno fmt.
The migration is complete—.dprint.json and tools/format.ts have been removed, and the CI now uses only deno fmt --check with Deno's default formatting rules. No configuration issues.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.26%. Comparing base (0c7f83e) to head (c3752aa).
⚠️ Report is 393 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1261      +/-   ##
==========================================
- Coverage   81.43%   80.26%   -1.18%     
==========================================
  Files          97      105       +8     
  Lines       23877    27783    +3906     
==========================================
+ Hits        19445    22300    +2855     
- Misses       4432     5483    +1051     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines -11 to -17
"exec": {
"cwd": "${configDir}",
"commands": [{
"command": "rustfmt",
"exts": ["rs"]
}]
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was ensuring that Rust code was formatted too and now it's lost. Can you add the check to the CI script?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants