-
Notifications
You must be signed in to change notification settings - Fork 135
chore: use deno fmt
#1261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: use deno fmt
#1261
Conversation
WalkthroughThis pull request removes the custom dprint-based formatting configuration and replaces it with Deno's native formatter. The changes include deleting Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
ops/op2/valid_args.md (1)
25-36: Doc additions look consistent; consider “buffer” wording for raw pointers.
For*mut u8/*const u8rows, “contents of the slice” reads a bit odd since these are pointers; “contents of the buffer” (or “memory”) would be slightly clearer if you want to tighten language.Also applies to: 40-56
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.dprint.json(0 hunks).github/workflows/ci-job.yml(1 hunks).github/workflows/ci-lint/action.yml(1 hunks).github/workflows/ci.yml(2 hunks)ops/op2/valid_args.md(1 hunks)tools/format.ts(0 hunks)
💤 Files with no reviewable changes (2)
- .dprint.json
- tools/format.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
- GitHub Check: build-linux / linux test
- GitHub Check: build-linux / linux coverage
- GitHub Check: build-linux-arm / linux-arm lint
- GitHub Check: build-windows / windows lint
- GitHub Check: build-linux-arm / linux-arm test
- GitHub Check: build-windows / windows test
- GitHub Check: build-macos / macos lint
- GitHub Check: build-linux / linux lint-deps
- GitHub Check: build-linux-arm / linux-arm test-miri
- GitHub Check: build-linux / linux test-ops
- GitHub Check: build-linux / linux test-miri
- GitHub Check: build-macos / macos test
🔇 Additional comments (4)
.github/workflows/ci-job.yml (1)
133-144: No functional change; indentation-only tweak is safe.
The comment stays correctly underenv:and won’t affect evaluation..github/workflows/ci.yml (2)
6-11: Quoting the tag wildcard is a safe clarity improvement.
Avoids YAML edge-cases around*and keeps intent explicit.
26-32: Matrix expression change is formatting-only; semantics preserved.
The||fallback chain is unchanged..github/workflows/ci-lint/action.yml (1)
5-11: Good switch todeno fmt.
The migration is complete—.dprint.jsonandtools/format.tshave been removed, and the CI now uses onlydeno fmt --checkwith Deno's default formatting rules. No configuration issues.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1261 +/- ##
==========================================
- Coverage 81.43% 80.26% -1.18%
==========================================
Files 97 105 +8
Lines 23877 27783 +3906
==========================================
+ Hits 19445 22300 +2855
- Misses 4432 5483 +1051 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| "exec": { | ||
| "cwd": "${configDir}", | ||
| "commands": [{ | ||
| "command": "rustfmt", | ||
| "exts": ["rs"] | ||
| }] | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was ensuring that Rust code was formatted too and now it's lost. Can you add the check to the CI script?
Seems to do the same job fine.