refactor: internal ops are under Deno.core.coreOps #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
commented
Feb 1, 2024
There was a problem hiding this comment.
This file should probably be rolled into 01_core.js to avoid having to expose these APIs to Deno.core
| } | ||
|
|
||
| /// Set up JavaScript bindings for ops. | ||
| pub(crate) fn initialize_deno_core_ops_bindings<'s>( |
There was a problem hiding this comment.
This function needs to be split into two separate functions - one for "core" ops and one for "ext" ops.
| throw new Error("boom"); | ||
| } | ||
| const { op_void_async, op_void_async_deferred } = Deno.core.ensureFastOps(); | ||
| const { opVoidAsync, opVoidAsyncDeferred } = Deno.core; |
There was a problem hiding this comment.
Need to verify it, but I believe deno relies on these ops as well
bartlomieju
commented
Feb 1, 2024
Comment on lines
127
to
+130
| .get(scope, key.into()) | ||
| .unwrap_or_else(|| panic!("{path} exists")) | ||
| .try_into() | ||
| .unwrap_or_else(|_| panic!("unable to convert")) | ||
| .unwrap_or_else(|_| panic!("Unable to convert {path} to desired type")) |
There was a problem hiding this comment.
This funciton should probably be a macro and accept a token tree to print out the desired type nicely
littledivy
reviewed
Feb 1, 2024
bartlomieju
commented
Feb 1, 2024
Comment on lines
+116
to
+132
| macro_rules! get_todo { | ||
| ($type:ty, $scope: expr, $from:expr, $key:expr, $path:literal) => {{ | ||
| let temp = v8_static_strings::new($scope, $key).into(); | ||
| TryInto::<$type>::try_into( | ||
| $from | ||
| .get($scope, temp) | ||
| .unwrap_or_else(|| panic!("{} exists", $path)), | ||
| ) | ||
| .unwrap_or_else(|_| { | ||
| panic!( | ||
| "Unable to convert {} to desired {}", | ||
| $path, | ||
| stringify!($type) | ||
| ) | ||
| }) | ||
| }}; | ||
| } |
There was a problem hiding this comment.
@mmastrac PTAL if this makes sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes how ops defined in "deno_core"
crate are exposed to JavaScript code.
They are no longer added to "Deno.core.ops", but to "Deno.core.coreOps",
to make the distinction between them more obvious.
All ops that are required for embedders are now available under "Deno.core"
namespace.
This refactor uncovered a lot of cruft and technical debt accumulated over the
years - eg. there are several ops that are added unconditionally that are only
ever used in testing code. This poses a question, if "deno_core" should expose
some of the ops only when
cfg(test)passes.