Skip to content

Conversation

gearonixx
Copy link

@gearonixx gearonixx commented Aug 29, 2024

Related issue: #885
Example usage: https://github.com/kurtexdev/kurtex/blob/main/crates/kurtex_core/src/deno/runtime.rs#L110

Look at the tests to understand in more detail what the functionality is about. The point is to update existing V8 modules with the old JsRuntime instance, without creating new ones.

Made for local purposes. But if you have any ideas, let me know, and I'll finish this PR.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 96.01770% with 9 lines in your changes missing coverage. Please review.

Project coverage is 82.02%. Comparing base (0c7f83e) to head (4b86793).
Report is 316 commits behind head on main.

Files with missing lines Patch % Lines
core/modules/module_map_data.rs 74.28% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #890      +/-   ##
==========================================
+ Coverage   81.43%   82.02%   +0.58%     
==========================================
  Files          97       98       +1     
  Lines       23877    25155    +1278     
==========================================
+ Hits        19445    20634    +1189     
- Misses       4432     4521      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@devsnek devsnek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on the use case here? If you just want hot reloading, for example, you should absolutely not do this and use the inspector hot patching api instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants