feat: add type resolution to TsTypeRefDef#781
Open
crowlKats wants to merge 2 commits intodocnodes-v2from
Open
Conversation
crowlKats
changed the title
dsherret
reviewed
Mar 11, 2026
Comment on lines
+780
to
+783
| fn find_type_param_origin( | ||
| module_info: &EsModuleInfo, | ||
| target_id: &Id, | ||
| ) -> Option<(String, TypeParamDeclaringKind)> { |
Member
There was a problem hiding this comment.
This seems strange. Can't we do "go to definition" with deno_graph::symbols?
Member
There was a problem hiding this comment.
dsherret
reviewed
Mar 11, 2026
| } else { | ||
| Some(TypeRefResolution::Local) | ||
| } | ||
| } else if ident.ctxt != module_info.source().unresolved_context() { |
Member
There was a problem hiding this comment.
Actually, why wouldn't there be a symbol for an id? I think I'm not understanding this code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #140