Skip to content

fix: make ts reference paths type-only deps#246

Merged
dsherret merged 1 commit intodenoland:mainfrom
nayeemrmn:ts-reference-path-is-type-dep
Mar 6, 2023
Merged

fix: make ts reference paths type-only deps#246
dsherret merged 1 commit intodenoland:mainfrom
nayeemrmn:ts-reference-path-is-type-dep

Conversation

@nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Mar 5, 2023

<reference path="..." /> doesn't create a runtime dependency. Extracted from #228.
Prevents the following module from failing on a no-check graph validation:

/// <reference path="./nonexistent.d.ts" />

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks!

@dsherret dsherret merged commit f160d06 into denoland:main Mar 6, 2023
@nayeemrmn nayeemrmn deleted the ts-reference-path-is-type-dep branch March 6, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants