Skip to content

fix: mark properties on NpmModule as deprecated #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsherret merged 2 commits into from
Oct 21, 2025
Merged

fix: mark properties on NpmModule as deprecated #621

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
243902a
fix: mark properties on NpmModule as deprecated
dsherret Oct 21, 2025
ef05531
fix
dsherret Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/graph.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1237,7 +1237,14 @@ static EMPTY_DEPS: std::sync::OnceLock<IndexMap<String, Dependency>> =
#[derive(Debug, Clone, Serialize)]
#[serde(rename_all = "camelCase")]
pub struct NpmModule {
// We need to change the NpmModule to instead only store an NpmReqReference
// and then map the req reference through the npm snapshot instead (have a single
// source of truth). This is necessary because deno_npm now does deduplication
// and so it will update on the fly the req to nv mapping, but then these
// properties in deno_graph won't get updated.
#[deprecated(since="0.103.1", note="Map the npm package req ref through the npm snapshot instead.")]
pub specifier: ModuleSpecifier,
#[deprecated(since="0.103.1", note="Map the npm package req ref through the npm snapshot instead.")]
#[serde(skip_serializing)]
pub nv_reference: NpmPackageNvReference,
}
Expand Down
Loading