feat: load source phase imports as assets#630
Merged
nayeemrmn merged 14 commits intodenoland:mainfrom Dec 8, 2025
Merged
Conversation
nayeemrmn
requested review from
bartlomieju,
dsherret and
nathanwhit
and removed request for
bartlomieju,
dsherret and
nathanwhit
dsherret
reviewed
Dec 3, 2025
Member
dsherret
left a comment
dsherret
left a comment
There was a problem hiding this comment.
Looks great! A few small comments.
nayeemrmn
commented
Dec 3, 2025
nayeemrmn
commented
Dec 4, 2025
dsherret
reviewed
Dec 4, 2025
nayeemrmn
commented
Dec 8, 2025
Comment on lines
+5085
to
+5088
| // TODO(nayeemrmn): We need to load the module to validate the actual | ||
| // media type for source-phase-import eligibility. Don't treat | ||
| // source-phase-imported modules as assets. Get the actual media type. | ||
| let inferred_media_type = MediaType::from_specifier(specifier); |
Collaborator
Author
There was a problem hiding this comment.
We need to download source-only targets so the media type is at least known. Most likely not for this PR though
Member
There was a problem hiding this comment.
This is a pretty big todo. We should work on it after this lands.
dsherret
approved these changes
Dec 8, 2025
Comment on lines
+5085
to
+5088
| // TODO(nayeemrmn): We need to load the module to validate the actual | ||
| // media type for source-phase-import eligibility. Don't treat | ||
| // source-phase-imported modules as assets. Get the actual media type. | ||
| let inferred_media_type = MediaType::from_specifier(specifier); |
Member
There was a problem hiding this comment.
This is a pretty big todo. We should work on it after this lands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.