feat: add no-unneeded-ternary rule #1034
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
im new to deno_lint but does this support the "quick fix" option from the LSP |
bartlomieju
requested changes
Apr 6, 2022
Comment on lines
3
to
17
| It's a common mistake to use a conditional expression to select between two | ||
| Boolean values instead of using ! to convert the test to a Boolean. | ||
|
|
||
| ### Invalid: | ||
|
|
||
| ```typescript | ||
| const foo = condition ? true : false; | ||
| ``` | ||
|
|
||
| ### Valid: | ||
|
|
||
| ```typescript | ||
| const foo = condition ? x : y; | ||
| const foo = condition ? x : false; | ||
| ``` |
There was a problem hiding this comment.
Could you add more examples? I still don't understand the purpose of this rule just from examples
There was a problem hiding this comment.
Sure. I think I need to add some comments to make it more clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1032