Skip to content

feat(verbatim-module-syntax): error for empty export declaration #1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsherret merged 2 commits into from
Aug 25, 2025
Merged

feat(verbatim-module-syntax): error for empty export declaration #1455

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b99fb1
feat(verbatim-module-syntax): error for empty export declaration
dsherret Aug 25, 2025
513eff6
format
dsherret Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
136 changes: 103 additions & 33 deletions src/rules/verbatim_module_syntax.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ use deno_ast::{
use derive_more::Display;

const CODE: &str = "verbatim-module-syntax";
const FIX_DESC: &str = "Add a type keyword";
const FIX_ADD_TYPE_KEYWORD_DESC: &str = "Add a type keyword";
const FIX_USE_IMPORT_DECL_DESC: &str = "Use an import declaration";

#[allow(clippy::enum_variant_names)]
#[derive(Display)]
Expand All @@ -32,6 +33,10 @@ enum Message {
AllExportIdentsUsedInTypes,
#[display(fmt = "Export identifier only used in types")]
ExportIdentUsedInTypes,
#[display(
fmt = "Empty export declaration elided without verbatim-module-syntax"
)]
ExportDeclarationElided,
}

#[derive(Display)]
Expand All @@ -44,6 +49,8 @@ enum Hint {
ChangeExportToExportType,
#[display(fmt = "Add a `type` keyword before the identifier")]
AddTypeKeyword,
#[display(fmt = "Change to side effect import for consistent behavior")]
ChangeSideEffectImport,
}

#[derive(Debug)]
Expand Down Expand Up @@ -108,7 +115,7 @@ impl VerbatimModuleSyntax {
Message::AllImportIdentsUsedInTypes,
Some(Hint::ChangeImportToImportType.to_string()),
vec![LintFix {
description: FIX_DESC.into(),
description: FIX_ADD_TYPE_KEYWORD_DESC.into(),
changes,
}],
);
Expand All @@ -120,7 +127,7 @@ impl VerbatimModuleSyntax {
Message::ImportIdentUsedInTypes,
Some(Hint::AddTypeKeyword.to_string()),
vec![LintFix {
description: FIX_DESC.into(),
description: FIX_ADD_TYPE_KEYWORD_DESC.into(),
changes: vec![LintFixChange {
new_text: "type ".into(),
range: specifier.start().range(),
Expand All @@ -138,10 +145,48 @@ impl VerbatimModuleSyntax {
context: &mut Context,
program: Program,
) {
if named_export.type_only()
|| named_export.specifiers.is_empty()
|| named_export.src.is_some()
{
if named_export.type_only() {
return;
}

if named_export.specifiers.is_empty() {
if let Some(src) = &named_export.src {
let quote_kind = if src.text_fast(program).starts_with("'") {
'\''
} else {
'\"'
};
let semicolon = if named_export.text_fast(program).ends_with(';') {
";"
} else {
""
};
let changes = Vec::from([LintFixChange {
new_text: format!(
"import {0}{1}{0}{2}",
quote_kind,
src.value(),
semicolon
)
.into(),
range: named_export.range(),
}]);
context.add_diagnostic_with_fixes(
named_export.range(),
CODE,
Message::ExportDeclarationElided,
Some(Hint::ChangeSideEffectImport.to_string()),
vec![LintFix {
description: FIX_USE_IMPORT_DECL_DESC.into(),
changes,
}],
);

return;
}
}

if named_export.specifiers.is_empty() || named_export.src.is_some() {
return;
}

Expand Down Expand Up @@ -189,7 +234,7 @@ impl VerbatimModuleSyntax {
Message::AllExportIdentsUsedInTypes,
Some(Hint::ChangeExportToExportType.to_string()),
vec![LintFix {
description: FIX_DESC.into(),
description: FIX_ADD_TYPE_KEYWORD_DESC.into(),
changes,
}],
);
Expand All @@ -201,7 +246,7 @@ impl VerbatimModuleSyntax {
Message::ExportIdentUsedInTypes,
Some(Hint::AddTypeKeyword.to_string()),
vec![LintFix {
description: FIX_DESC.into(),
description: FIX_ADD_TYPE_KEYWORD_DESC.into(),
changes: vec![LintFixChange {
new_text: "type ".into(),
range: specifier.start().range(),
Expand Down Expand Up @@ -390,6 +435,7 @@ mod tests {
"import { value, type Type } from 'module'; console.log(value); export type { Type };",
"import { value, type Type } from 'module'; export { value, type Type };",
"export { value } from './value.ts';",
"export {};",
"const logger = { setItems }; export { logger };",
"class Test {} export { Test };",
};
Expand All @@ -404,167 +450,191 @@ mod tests {
col: 0,
message: Message::AllImportIdentsUsedInTypes,
hint: Hint::ChangeImportToImportType,
fix: (FIX_DESC, "import type { Type } from 'module'; type Test = Type;"),
fix: (FIX_ADD_TYPE_KEYWORD_DESC, "import type { Type } from 'module'; type Test = Type;"),
}
],
"import { Type, Other } from 'module'; type Test = Type | Other;": [
{
col: 0,
message: Message::AllImportIdentsUsedInTypes,
hint: Hint::ChangeImportToImportType,
fix: (FIX_DESC, "import type { Type, Other } from 'module'; type Test = Type | Other;"),
fix: (FIX_ADD_TYPE_KEYWORD_DESC, "import type { Type, Other } from 'module'; type Test = Type | Other;"),
}
],
"import { type Type, Other } from 'module'; type Test = Type | Other;": [
{
col: 0,
message: Message::AllImportIdentsUsedInTypes,
hint: Hint::ChangeImportToImportType,
fix: (FIX_DESC, "import type { Type, Other } from 'module'; type Test = Type | Other;"),
fix: (FIX_ADD_TYPE_KEYWORD_DESC, "import type { Type, Other } from 'module'; type Test = Type | Other;"),
}
],
"import { Type, value } from 'module'; type Test = Type; value();": [
{
col: 9,
message: Message::ImportIdentUsedInTypes,
hint: Hint::AddTypeKeyword,
fix: (FIX_DESC, "import { type Type, value } from 'module'; type Test = Type; value();"),
fix: (FIX_ADD_TYPE_KEYWORD_DESC, "import { type Type, value } from 'module'; type Test = Type; value();"),
}
],
"import { Type, Other, value } from 'module'; type Test = Type | Other; value();": [
{
col: 9,
message: Message::ImportIdentUsedInTypes,
hint: Hint::AddTypeKeyword,
fix: (FIX_DESC, "import { type Type, Other, value } from 'module'; type Test = Type | Other; value();"),
fix: (FIX_ADD_TYPE_KEYWORD_DESC, "import { type Type, Other, value } from 'module'; type Test = Type | Other; value();"),
},
{
col: 15,
message: Message::ImportIdentUsedInTypes,
hint: Hint::AddTypeKeyword,
fix: (FIX_DESC, "import { Type, type Other, value } from 'module'; type Test = Type | Other; value();"),
fix: (FIX_ADD_TYPE_KEYWORD_DESC, "import { Type, type Other, value } from 'module'; type Test = Type | Other; value();"),
}
],
"import * as value from 'module'; type Test = typeof value;": [
{
col: 0,
message: Message::AllImportIdentsUsedInTypes,
hint: Hint::ChangeImportToImportType,
fix: (FIX_DESC, "import type * as value from 'module'; type Test = typeof value;"),
fix: (FIX_ADD_TYPE_KEYWORD_DESC, "import type * as value from 'module'; type Test = typeof value;"),
}
],
"import value from 'module'; type Test = typeof value;": [
{
col: 0,
message: Message::AllImportIdentsUsedInTypes,
hint: Hint::ChangeImportToImportType,
fix: (FIX_DESC, "import type value from 'module'; type Test = typeof value;"),
fix: (FIX_ADD_TYPE_KEYWORD_DESC, "import type value from 'module'; type Test = typeof value;"),
}
],
"type Test = string; export { Test };": [
{
col: 20,
message: Message::AllExportIdentsUsedInTypes,
hint: Hint::ChangeExportToExportType,
fix: (FIX_DESC, "type Test = string; export type { Test };"),
fix: (FIX_ADD_TYPE_KEYWORD_DESC, "type Test = string; export type { Test };"),
}
],
"type Test = string; type Test2 = string; export { Test, Test2 };": [
{
col: 41,
message: Message::AllExportIdentsUsedInTypes,
hint: Hint::ChangeExportToExportType,
fix: (FIX_DESC, "type Test = string; type Test2 = string; export type { Test, Test2 };"),
fix: (FIX_ADD_TYPE_KEYWORD_DESC, "type Test = string; type Test2 = string; export type { Test, Test2 };"),
}
],
"import { type value } from 'module'; export { value };": [
{
col: 0,
message: Message::AllImportIdentsUsedInTypes,
hint: Hint::ChangeImportToImportType,
fix: (FIX_DESC, "import type { value } from 'module'; export { value };"),
fix: (FIX_ADD_TYPE_KEYWORD_DESC, "import type { value } from 'module'; export { value };"),
},
{
col: 37,
message: Message::AllExportIdentsUsedInTypes,
hint: Hint::ChangeExportToExportType,
fix: (FIX_DESC, "import { type value } from 'module'; export type { value };"),
fix: (FIX_ADD_TYPE_KEYWORD_DESC, "import { type value } from 'module'; export type { value };"),
}
],
"import { value } from 'module'; export { type value };": [
{
col: 0,
message: Message::AllImportIdentsUsedInTypes,
hint: Hint::ChangeImportToImportType,
fix: (FIX_DESC, "import type { value } from 'module'; export { type value };"),
fix: (FIX_ADD_TYPE_KEYWORD_DESC, "import type { value } from 'module'; export { type value };"),
},
{
col: 32,
message: Message::AllExportIdentsUsedInTypes,
hint: Hint::ChangeExportToExportType,
fix: (FIX_DESC, "import { value } from 'module'; export type { value };"),
fix: (FIX_ADD_TYPE_KEYWORD_DESC, "import { value } from 'module'; export type { value };"),
}
],
"import type { value } from 'module'; export { value };": [
{
col: 37,
message: Message::AllExportIdentsUsedInTypes,
hint: Hint::ChangeExportToExportType,
fix: (FIX_DESC, "import type { value } from 'module'; export type { value };"),
fix: (FIX_ADD_TYPE_KEYWORD_DESC, "import type { value } from 'module'; export type { value };"),
}
],
"import { value } from 'module'; export type { value };": [
{
col: 0,
message: Message::AllImportIdentsUsedInTypes,
hint: Hint::ChangeImportToImportType,
fix: (FIX_DESC, "import type { value } from 'module'; export type { value };"),
fix: (FIX_ADD_TYPE_KEYWORD_DESC, "import type { value } from 'module'; export type { value };"),
}
],
"import { value, type Type } from 'module'; console.log(value); export { Type };": [
{
col: 63,
message: Message::AllExportIdentsUsedInTypes,
hint: Hint::ChangeExportToExportType,
fix: (FIX_DESC, "import { value, type Type } from 'module'; console.log(value); export type { Type };"),
fix: (FIX_ADD_TYPE_KEYWORD_DESC, "import { value, type Type } from 'module'; console.log(value); export type { Type };"),
}
],
"import { value, Type } from 'module'; console.log(value); export { type Type };": [
{
col: 16,
message: Message::ImportIdentUsedInTypes,
hint: Hint::AddTypeKeyword,
fix: (FIX_DESC, "import { value, type Type } from 'module'; console.log(value); export { type Type };"),
fix: (FIX_ADD_TYPE_KEYWORD_DESC, "import { value, type Type } from 'module'; console.log(value); export { type Type };"),
},
{
col: 58,
message: Message::AllExportIdentsUsedInTypes,
hint: Hint::ChangeExportToExportType,
fix: (FIX_DESC, "import { value, Type } from 'module'; console.log(value); export type { Type };"),
fix: (FIX_ADD_TYPE_KEYWORD_DESC, "import { value, Type } from 'module'; console.log(value); export type { Type };"),
}
],
"import { value, Type } from 'module'; console.log(value); export type { Type };": [
{
col: 16,
message: Message::ImportIdentUsedInTypes,
hint: Hint::AddTypeKeyword,
fix: (FIX_DESC, "import { value, type Type } from 'module'; console.log(value); export type { Type };"),
fix: (FIX_ADD_TYPE_KEYWORD_DESC, "import { value, type Type } from 'module'; console.log(value); export type { Type };"),
}
],
"import { value, type Type } from 'module'; export { value, Type };": [
{
col: 59,
message: Message::ExportIdentUsedInTypes,
hint: Hint::AddTypeKeyword,
fix: (FIX_DESC, "import { value, type Type } from 'module'; export { value, type Type };"),
fix: (FIX_ADD_TYPE_KEYWORD_DESC, "import { value, type Type } from 'module'; export { value, type Type };"),
}
],
"import { value, Type } from 'module'; export { value, type Type };": [
{
col: 16,
message: Message::ImportIdentUsedInTypes,
hint: Hint::AddTypeKeyword,
fix: (FIX_DESC, "import { value, type Type } from 'module'; export { value, type Type };"),
fix: (FIX_ADD_TYPE_KEYWORD_DESC, "import { value, type Type } from 'module'; export { value, type Type };"),
}
],
"export { } from 'module';": [
{
col: 0,
message: Message::ExportDeclarationElided,
hint: Hint::ChangeSideEffectImport,
fix: (FIX_USE_IMPORT_DECL_DESC, "import 'module';"),
}
],
"export { } from \"module\";": [
{
col: 0,
message: Message::ExportDeclarationElided,
hint: Hint::ChangeSideEffectImport,
fix: (FIX_USE_IMPORT_DECL_DESC, "import \"module\";"),
}
],
"export { } from \"module\"": [
{
col: 0,
message: Message::ExportDeclarationElided,
hint: Hint::ChangeSideEffectImport,
fix: (FIX_USE_IMPORT_DECL_DESC, "import \"module\""),
}
],
"interface Test {}\nexport { Test };": [
Expand All @@ -573,7 +643,7 @@ mod tests {
col: 0,
message: Message::AllExportIdentsUsedInTypes,
hint: Hint::ChangeExportToExportType,
fix: (FIX_DESC, "interface Test {}\nexport type { Test };"),
fix: (FIX_ADD_TYPE_KEYWORD_DESC, "interface Test {}\nexport type { Test };"),
}
],
"type Test = 'test';\nexport { Test };": [
Expand All @@ -582,7 +652,7 @@ mod tests {
col: 0,
message: Message::AllExportIdentsUsedInTypes,
hint: Hint::ChangeExportToExportType,
fix: (FIX_DESC, "type Test = 'test';\nexport type { Test };"),
fix: (FIX_ADD_TYPE_KEYWORD_DESC, "type Test = 'test';\nexport type { Test };"),
}
],
};
Expand Down
Loading