feat: put npm packument info in lockfile #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwhit
commented
Mar 26, 2025
| )] | ||
| pub struct MissingNpmPackageInfo; | ||
|
|
||
| pub async fn transform4_to_5( |
There was a problem hiding this comment.
this is async because this transform needs info about the npm packages (which might need to be downloaded). it's annoying because it infects the rest of the API for loading a lockfile
nathanwhit
commented
Mar 26, 2025
| }) | ||
| } | ||
|
|
||
| pub fn new_current_version( |
There was a problem hiding this comment.
added this to have a sync way to make a lockfile. if it needs to do the async transform, it returns an error (which the caller needs to handle). this is also useful for tests and other places where you know the lockfile is already on the latest version
nathanwhit
commented
Mar 26, 2025
| async fn get_npm_package_info( | ||
| &self, | ||
| values: &[PackageNv], | ||
| ) -> Result<Vec<Lockfile5NpmInfo>, Box<dyn std::error::Error + Send + Sync>>; |
There was a problem hiding this comment.
needs a better error type
This was referenced Mar 27, 2025
dsherret
reviewed
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.