feat: configurable shell options and shopt command#164
Merged
dsherret merged 3 commits intodenoland:mainfrom Jan 20, 2026
Merged
feat: configurable shell options and shopt command#164dsherret merged 3 commits intodenoland:mainfrom
shopt command#164dsherret merged 3 commits intodenoland:mainfrom
Conversation
bartlomieju
approved these changes
Jan 20, 2026
| mut context: ShellCommandContext, | ||
| ) -> LocalBoxFuture<'static, ExecuteResult> { | ||
| Box::pin(async move { | ||
| let mut set_mode = None; // None = query, Some(true) = -s, Some(false) = -u |
Member
There was a problem hiding this comment.
Is this written by AI? :D This combination is strange compared to using an enum
Member
Author
There was a problem hiding this comment.
Yes, but I don’t think it’s that strange because each individual one can be set in an iteration of the loop.
Oh wait, I misunderstood this when I originally commented, but I think Option<bool> makes sense here.
Contributor
|
Thanks! This is great! |
Member
Author
|
I just remembered about the windows |
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports configuring the following shell options:
nullglobfailglobCloses #162