-
Notifications
You must be signed in to change notification settings - Fork 35
Update rusqlite from 0.34.0 to 0.37.0 #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This update addresses a dependency version conflict and aligns with the latest rusqlite API changes. In rusqlite 0.35+, the DatabaseName enum was removed in favor of using string literals directly for database names. This change simplifies the API by using SQLite's native string-based naming convention. Changes: - Updated rusqlite dependency from 0.34.0 to 0.37.0 - Removed DatabaseName import from sqlite/backend.rs - Replaced DatabaseName::Main with "main" string literal in is_readonly() call All existing tests pass with these changes.
|
This would be a prerequisite for denoland/deno#31274 |
|
cargo build works correctly, not exactly sure how to fix pipeline tests libsqlite3-sys . where is that dependency from ? |
bartlomieju
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update rusqlite in npm/napi too, this should get CI passing
|
I forgot to look into independent nested Cargo.toml as this is not a workspace setup with joined dependencies, sorry for that. |
|
@matthiasg I tried pushing to your branch, but I'm not able too - I think this needs one, last change - can you update |
sorry this took so long. |
|
@matthiasg can you please make sure that the checkbox for updates from maintainers is checked on the right hand side of the menu on PR page? I'll edit the PR then and make sure it lands |
|
Quite the can of worms :) this stems from https://github.com/napi-rs/napi-rs/blob/6449f7d31059d8da0d8ac7435a9e405deb11cdb1/Cargo.toml#L20 |
Supersedes #131 --------- Co-authored-by: Matthias Goetzke <[email protected]>
|
thanks, merged in #132 |
Updating the rusqlite dependency to the more recent release.
In rusqlite 0.35+, the DatabaseName enum was removed in favor of using string literals directly for database names. This change simplifies the API by using SQLite's native string-based naming convention.
Changes: