Skip to content

Conversation

@matthiasg
Copy link
Contributor

Updating the rusqlite dependency to the more recent release.

In rusqlite 0.35+, the DatabaseName enum was removed in favor of using string literals directly for database names. This change simplifies the API by using SQLite's native string-based naming convention.

Changes:

  • Updated rusqlite dependency from 0.34.0 to 0.37.0
  • Removed DatabaseName import from sqlite/backend.rs
  • Replaced DatabaseName::Main with "main" string literal in is_readonly() call

This update addresses a dependency version conflict and aligns with the
latest rusqlite API changes.

In rusqlite 0.35+, the DatabaseName enum was removed in favor of using
string literals directly for database names. This change simplifies the
API by using SQLite's native string-based naming convention.

Changes:
- Updated rusqlite dependency from 0.34.0 to 0.37.0
- Removed DatabaseName import from sqlite/backend.rs
- Replaced DatabaseName::Main with "main" string literal in is_readonly() call

All existing tests pass with these changes.
@matthiasg
Copy link
Contributor Author

This would be a prerequisite for denoland/deno#31274

@matthiasg
Copy link
Contributor Author

cargo build works correctly, not exactly sure how to fix pipeline tests libsqlite3-sys . where is that dependency from ?

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update rusqlite in npm/napi too, this should get CI passing

@matthiasg
Copy link
Contributor Author

I forgot to look into independent nested Cargo.toml as this is not a workspace setup with joined dependencies, sorry for that.

@bartlomieju
Copy link
Member

@matthiasg I tried pushing to your branch, but I'm not able too - I think this needs one, last change - can you update rust-toolchain.toml to specify 1.91.0 instead of 1.86.0? This should make the build happy

@matthiasg
Copy link
Contributor Author

rust-toolchain.toml

sorry this took so long.

@bartlomieju
Copy link
Member

@matthiasg can you please make sure that the checkbox for updates from maintainers is checked on the right hand side of the menu on PR page? I'll edit the PR then and make sure it lands

@matthiasg
Copy link
Contributor Author

matthiasg commented Nov 20, 2025

Quite the can of worms :)

  [email protected] requires rustc 1.88
Either upgrade rustc or select compatible dependency versions with
`cargo update <name>@<current-ver> --precise <compatible-ver>`
where `<compatible-ver>` is the latest version supporting rustc 1.86.0

this stems from https://github.com/napi-rs/napi-rs/blob/6449f7d31059d8da0d8ac7435a9e405deb11cdb1/Cargo.toml#L20

bartlomieju added a commit that referenced this pull request Nov 21, 2025
Supersedes #131

---------

Co-authored-by: Matthias Goetzke <[email protected]>
@bartlomieju
Copy link
Member

thanks, merged in #132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants