fix: report failed check indexes in AtomicWriteOutput#150
Merged
Conversation
The self-hosted server always returned an empty failed_checks list when an atomic write failed its checks, unlike the cloud implementation. Clients use the indexes to re-read only the conflicting keys before retrying. * the sqlite backend now evaluates every check instead of stopping at the first failure, and returns the failing indexes * a new AtomicWriteOutcome enum carries the outcome through the inherent Sqlite::atomic_write path used by the denokv server and the napi bindings; the denokv_proto::Database trait is unchanged (its impl drops the indexes, preserving the existing interface for trait consumers) * an integration test exercises the wire format end to end Fixes #110.
The prose referred to AW_CHECK_FAILED and check_failures; the actual schema names are AW_CHECK_FAILURE and failed_checks. Also fixes a typo (interpereting).
piscisaureus
force-pushed
the
failed-checks
branch
from
b42d851 to
f6ebe30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The self-hosted server always returned an empty failed_checks list
when an atomic write failed its checks, unlike the cloud
implementation. Clients use the indexes to re-read only the
conflicting keys before retrying.
at the first failure, and returns the failing indexes
inherent Sqlite::atomic_write path used by the denokv server and
the napi bindings; the denokv_proto::Database trait is unchanged
(its impl drops the indexes, preserving the existing interface for
trait consumers)
Fixes #110.