fix: sync generated protobuf ts files with the datapath schema#152
Merged
Conversation
Regenerated with pbkit from proto/schema/datapath.proto. The generated TypeScript was missing the M_SET_SUFFIX_VERSIONSTAMPED_KEY mutation type and the sum_min / sum_max / sum_clamp fields on Mutation. The Mutation message construction in proto_based.ts gains the new fields with proto3 default values, leaving the wire encoding of existing mutation types unchanged. Fixes #87.
piscisaureus
force-pushed
the
sync-proto-ts
branch
from
7afafab to
d475c8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerated with pbkit from proto/schema/datapath.proto. The
generated TypeScript was missing the M_SET_SUFFIX_VERSIONSTAMPED_KEY
mutation type and the sum_min / sum_max / sum_clamp fields on
Mutation. The Mutation message construction in proto_based.ts gains
the new fields with proto3 default values, leaving the wire encoding
of existing mutation types unchanged.
Fixes #87.