fix: match native Deno.Kv.list selector validation#157
Merged
Conversation
The npm package's list selector handling diverged from the native implementation in three ways (#130): * selector keys with undefined values were treated as present because presence was tested with the 'in' operator, so { prefix, start: undefined, end: undefined } was rejected * range keys outside the keyspace defined by the prefix were accepted instead of raising the native TypeError * incomplete selectors ({ start } only, { end } only, {}) crashed with a confusing 'flatMap of undefined' error instead of the native 'Selector must specify either prefix or both start and end key' TypeError checkListSelector now normalizes the selector exactly like the native JS layer (dropping undefined-valued keys) and applies the native byte-level keyspace and ordering checks, returning the normalized selector that the list implementations consume. Fixes #130.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The npm package's list selector handling diverged from the native
implementation in three ways (#130):
because presence was tested with the 'in' operator, so
{ prefix, start: undefined, end: undefined } was rejected
accepted instead of raising the native TypeError
with a confusing 'flatMap of undefined' error instead of the
native 'Selector must specify either prefix or both start and
end key' TypeError
checkListSelector now normalizes the selector exactly like the
native JS layer (dropping undefined-valued keys) and applies the
native byte-level keyspace and ordering checks, returning the
normalized selector that the list implementations consume.
Fixes #130.