fix: update getDntVersion function to support JSR registry URLs - #484
Merged
Conversation
Contributor
Author
Contributor
Author
|
after that issue, i have tried to solve the issue #454 too. you may check the updates, any recommendation, or updates, then let me know |
Contributor
Author
|
Hi @dsherret , following up on this. I realized I bundled two distinct changes here: the JSR URL fix (#481 ) and the globalThis/shim options (#454 ). If you prefer, I can strictly revert this PR to just the JSR fix and open a separate PR for the shim options to keep the history clean. Just let me know your preference! |
Collaborator
|
This has a bunch of unrelated changes. Can you keep it focused to the fix? |
getDntVersion function to support JSR registry URLs
Collaborator
|
I went ahead and updated. I'll see about landing your other changes in other focused PRs (with attribution). |
Contributor
Author
|
@dsherret Thank You! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
getDntVersionfunction inutils.tsto correctly extract version numbers from JSR URLs, as mentioned in the issue #481 , in addition to the existing Deno Land URLs. The regex has been modified to match both /dnt@version/ (legacy) and /@deno/dnt/version/ (JSR) patterns.Previously, when dnt was imported from JSR,
getDntVersion()would always return "dev" because the URL format wasn't recognized. Now it properly extracts the version (e.g., "1.2.3") from JSR URLs like https://jsr.io/@deno/dnt/1.2.3/mod.ts.Testing: