fix: type check failure in import.meta polyfill with newer @types/node - #499
Merged
Merged
Conversation
`@types/node` (>=22.16.3) declares `ImportMeta.resolve`, which merges with the polyfill's own declaration into an overload set. That provides no contextual type for the assigned function's parameters, so `parentURL` was inferred as `unknown` and failed to type check when passed to `createRequire`. Closes denoland#472
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@types/node(>=22.16.3) declaresImportMeta.resolve, which merges with the polyfill's own declaration into an overload set. That provides no contextual type for the assigned function's parameters, soparentURLwas inferred asunknownand failed to type check when passed tocreateRequire:This only surfaced when the
domlib was included, so the regression test builds the import meta polyfill project withlib: ["ES2022", "DOM"]and@types/node@^22.16.3(it fails without the fix).Closes #472