fix: keep the property name when shimming a shorthand property - #510
Merged
Conversation
An object literal shorthand property whose name was a shimmed global
emitted invalid code (ex. `{ prompt }` became `{ dntShim.prompt }`),
which the compiler then silently emitted as garbage.
Closes denoland#329
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #329
An object literal shorthand property whose name is a shimmed global emitted invalid code. For example, this:
...emitted this to
src/:...which the compiler then silently emitted as
{ dntShim, : .prompt, }in the output. Now the property name is kept:This applies to the
globalThisandwindowreplacements as well ({ window }was becoming{ globalThis }, which quietly renamed the property).Only a shorthand property is affected — a computed key, spread, or explicit key that happens to use a shimmed global still resolves the way it did before.