feat: warn when using the separate declaration option with a script output - #513
Merged
Merged
Conversation
…utput The declarations describe the ESM output, so sharing them with the CommonJS/UMD output isn't correct for a CommonJS consumer. Closes denoland#327
- don't use a jsdoc tag, which applied the deprecation to the whole option - only warn when there's both an esm and a script output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #327
Per your comment on the issue, this warns when
declaration: "separate"is used alongside a CommonJS/UMD output:There's no warning when
scriptModuleisfalse, since there's only the one output for the declarations to describe.The option's jsdoc also gets a
@deprecatednote pointing at"inline".