doc: add a note about how to consume DenoRT #1189
Conversation
Add documentation about how to consume DenoRT when building Deno from source. Fixes: denoland/deno#27035
| @@ -244,3 +244,19 @@ version instead of fetching it from `crates.io`. | |||
| `Cargo.toml` match the version of the dependencies you have on disk. | |||
|
|
|||
| Use `cargo search <dependency_name>` to inspect the versions. | |||
|
|
|||
| ## Consuming the DenoRT | |||
There was a problem hiding this comment.
Instead of needing to document this and for people to do this (which they probably will likely not read/remember this), it might be nice for this to automatically happen when running deno compile from a target/... directory.
There was a problem hiding this comment.
I've not seen the RFC for this, but this was in the comments of get_base_binary:
// Phase 2 of the 'min sized' deno compile RFC talks
// about adding this as a flag.
Having it automatically use the compiled DenoRT when the path includes target/ seems like The principle of least surprise. That seems better than both the flag & env variable approach. I will often sym link my debug build into /Users/irbull/.cargo/bin/deno, and maybe we can also handle this case.
If you're interested, I could take a stab at this. I don't have too much time today to dive into it, but I could find some time this week.
There was a problem hiding this comment.
I had a bit of time today between kids sports, so I brought my laptop to the rink and put this PR together: denoland/deno#27052
I'll close this one.
Add documentation about how to consume DenoRT when building Deno from source.
Fixes: denoland/deno#27035