Switch hover back to default; minor styles adjustment#2431
Merged
josh-collinsworth merged 6 commits intomainfrom Aug 8, 2025
Merged
Switch hover back to default; minor styles adjustment#2431josh-collinsworth merged 6 commits intomainfrom
josh-collinsworth merged 6 commits intomainfrom
Conversation
| @import "tailwindcss"; | ||
|
|
||
| @theme { | ||
| @theme static { |
Contributor
Author
| @apply text-deploy-500 decoration-deploy-500/20 hover:decoration-deploy-500; | ||
| } | ||
|
|
||
| .learn-link { |
Contributor
Author
There was a problem hiding this comment.
These are actually changes that got missed from a separate PR but that have no visible effect.
We don't need the !s anymore now that we've got layers, and the .learn-link class isn't in the markup anymore (since it's only rendered in one place, so it made more sense to just move the classes there instead of having a separate @apply block).
| <img | ||
| src="/img/light.svg" | ||
| class="w-full block -translate-y-full dark:translate-y-0 transition-transform duration-200 easing-[0.86,0,0.07,1]" | ||
| alt="" |
Collaborator
There was a problem hiding this comment.
should there be some text in the alts? Does it matter?
Contributor
Author
There was a problem hiding this comment.
There's accessible text inside the button to describe its function already, so I don't think adding image descriptions here is probably beneficial. The empty alt just lets the images be ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Mostly just restores the default
:hoverbehavior, so that hover effects trigger on both fine and coarse pointer devices. Also includes a couple other small CSS fixups.