Skip to content

Switch hover back to default; minor styles adjustment#2431

Merged
josh-collinsworth merged 6 commits into
mainfrom
joco/hover_fix
Aug 8, 2025
Merged

Switch hover back to default; minor styles adjustment#2431
josh-collinsworth merged 6 commits into
mainfrom
joco/hover_fix

Conversation

@josh-collinsworth

@josh-collinsworth josh-collinsworth commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

Mostly just restores the default :hover behavior, so that hover effects trigger on both fine and coarse pointer devices. Also includes a couple other small CSS fixups.

Comment thread styles.css
@import "tailwindcss";

@theme {
@theme static {

@josh-collinsworth josh-collinsworth Aug 7, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ensures our default theme color variables are not tree-shaken. Adds a tiny bit of extra CSS to the final output, but lets you play with all the variables in the browser as needed.

image

Comment thread styles.css
@apply text-deploy-500 decoration-deploy-500/20 hover:decoration-deploy-500;
}

.learn-link {

@josh-collinsworth josh-collinsworth Aug 7, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are actually changes that got missed from a separate PR but that have no visible effect.

We don't need the !s anymore now that we've got layers, and the .learn-link class isn't in the markup anymore (since it's only rendered in one place, so it made more sense to just move the classes there instead of having a separate @apply block).

@thisisjofrank thisisjofrank left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love

<img
src="/img/light.svg"
class="w-full block -translate-y-full dark:translate-y-0 transition-transform duration-200 easing-[0.86,0,0.07,1]"
alt=""

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be some text in the alts? Does it matter?

@josh-collinsworth josh-collinsworth Aug 7, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's accessible text inside the button to describe its function already, so I don't think adding image descriptions here is probably beneficial. The empty alt just lets the images be ignored.

@thisisjofrank thisisjofrank left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo such hover.

@josh-collinsworth josh-collinsworth merged commit f6537b8 into main Aug 8, 2025
5 checks passed
@thisisjofrank thisisjofrank deleted the joco/hover_fix branch August 8, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants