Skip to content

feat: Crons#2922

Merged
thisisjofrank merged 8 commits intomainfrom
crons
Mar 2, 2026
Merged

feat: Crons#2922
thisisjofrank merged 8 commits intomainfrom
crons

Conversation

@arnauorriols
Copy link
Member

@arnauorriols arnauorriols commented Feb 20, 2026

@arnauorriols
Copy link
Member Author

arnauorriols commented Feb 23, 2026

  • Be more explicit about crons being scheduled to each timeline right after explaining how to declare them.

## Limitations

- Crons must be registered at the module top level (before `Deno.serve()`)
- No concurrent executions of the same cron
Copy link
Member

@philhawksworth philhawksworth Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • No concurrent executions of the same cron

What exactly does that mean? Could we be a tiny bit more descriptive here in the interest of driving out any ambiguity?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, besides the billing point, the rest are already explained in length above. I'm considering removing the section alltogether, and adding a billing section explaining how billing works

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arnauorriols are we happy with this as is or still need removing?

Copy link
Member

@philhawksworth philhawksworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

I've added some questions and comments.

A fundamental one is about the naming of this as Crons vs Cron, which might bring about the need for a few edits for consistency depending on what is decided.

Copy link
Member

@philhawksworth philhawksworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@thisisjofrank thisisjofrank merged commit b0a57b1 into main Mar 2, 2026
1 of 2 checks passed
@thisisjofrank thisisjofrank deleted the crons branch March 2, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants