docs: clarify that Deno runtime flags can't be passed on Deploy#3310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feedback on the builds reference asked how to pass Deno runtime arguments such
as
--unstable-*on Deno Deploy, and couldn't find an answer.The answer already lives in the runtime reference ("the runtime runs with
--allow-all" and "custom flags cannot be passed to the Deno runtime"), but itwasn't surfaced on the builds page, where the "Arguments" /
deploy.runtime.argsoption is described only as "command-line arguments to pass to the application".
That wording reads as if it might cover runtime flags, when in fact those
arguments go to the application after the entrypoint.
This clarifies both the dashboard "Arguments" option and the
deploy.runtime.argssource-code option to say the arguments are passed to the application after the
entrypoint and are not Deno runtime flags, with a link to the runtime reference.
It also names
--unstable-*explicitly in the runtime reference so the term issearchable from where users look.
Closes #2398.