docs: clarify that custom spans nest under request traces#3313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the Observability
page, the Traces section explains the parent/child waterfall view but
never states that the Traces list itself only shows top-level request
traces. Users who add custom spans via manual instrumentation expect to
see them as standalone entries and get confused when they don't appear.
This adds a short clarification that custom spans show up as children
nested within the request trace they run under, and that you find them by
opening the relevant request trace. This matches the behavior a
maintainer confirmed in #2492.
Refs #2492. The remaining items in that issue (surfacing span events in
the dashboard, and traces for non-request contexts) are Deno Deploy
product behaviors rather than documentation changes.