Skip to content

update deno_npm with packument changes#209

Merged
nathanwhit merged 1 commit intodenoland:mainfrom
nathanwhit:lockfile-packument-take-2
Apr 3, 2025
Merged

update deno_npm with packument changes#209
nathanwhit merged 1 commit intodenoland:mainfrom
nathanwhit:lockfile-packument-take-2

Conversation

@nathanwhit
Copy link
Member

No description provided.

@nathanwhit nathanwhit requested review from Copilot and dsherret April 3, 2025 01:56
@CLAassistant
Copy link

CLAassistant commented Apr 3, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the npm packument handling in the code and bumps the version of the deno_npm dependency to align with upstream changes.

  • Introduces new fields (extra, is_deprecated, has_bin, has_scripts, optional_peer_dependencies) in npm metadata structures.
  • Removes the outdated fields (bin, scripts, deprecated) from the packument handling code.
  • Updates Cargo.toml to use deno_npm version "0.31.0" in place of "0.27.2".

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/v2.rs Modifies npm metadata structure to adopt new packument fields.
Cargo.toml Bumps the deno_npm version to match packument format changes.
Comments suppressed due to low confidence (2)

src/v2.rs:1795

  • Since the npm packument structure has been updated, please ensure that all existing code interacting with npm metadata is revised to handle the new fields and the removal of the old ones.
      extra: Default::default(),

Cargo.toml:54

  • The deno_npm version update may introduce breaking changes; please verify that all updated code is compatible with the new version and that relevant documentation is updated accordingly.
deno_npm = { version = "0.31.0" }

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanwhit nathanwhit merged commit 6edff58 into denoland:main Apr 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants