Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/src/island.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ export function DemoIsland(): JSX.Element {

return (
<div style="display: flex; gap: 1rem; padding: 2rem;">
<button onClick={() => (count.value -= 1)}>-1</button>
<button type="button" onClick={() => (count.value -= 1)}>-1</button>
<p style="font-variant-numeric: tabular-nums;">{count}</p>
<button onClick={() => (count.value += 1)}>+1</button>
<button type="button" onClick={() => (count.value += 1)}>+1</button>
</div>
);
}
7 changes: 6 additions & 1 deletion src/dev/middlewares/error_overlay/overlay.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,12 @@ export function ErrorOverlay(props: { url: URL }) {
<style dangerouslySetInnerHTML={{ __html: errorCss }} />
<div class="inner">
<div class="header">
<button class="close-btn" aria-label="close" id="close-btn">
<button
type="button"
class="close-btn"
aria-label="close"
id="close-btn"
>
<svg
xmlns="http://www.w3.org/2000/svg"
fill="none"
Expand Down
12 changes: 10 additions & 2 deletions tests/fixtures_islands/Counter.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,19 @@ export function Counter(props: CounterProps) {

return (
<div id={props.id} class={active.value ? "ready" : ""}>
<button class="decrement" onClick={() => props.count.value -= 1}>
<button
type="button"
class="decrement"
onClick={() => props.count.value -= 1}
>
-1
</button>
<p class="output">{props.count}</p>
<button class="increment" onClick={() => props.count.value += 1}>
<button
type="button"
class="increment"
onClick={() => props.count.value += 1}
>
+1
</button>
</div>
Expand Down
4 changes: 3 additions & 1 deletion tests/fixtures_islands/CounterWithSlots.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ export function CounterWithSlots(
<div class={active.value ? "ready" : ""}>
<div class="counter-with-children">
<p class="output">{sig}</p>
<button onClick={() => sig.value = sig.peek() + 1}>update</button>
<button type="button" onClick={() => sig.value = sig.peek() + 1}>
update
</button>
</div>
<div class="children">
{props.children}
Expand Down
1 change: 1 addition & 0 deletions tests/fixtures_islands/FragmentIsland.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// deno-lint-ignore-file jsx-curly-braces
export function FragmentIsland() {
return (
<>
Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures_islands/FreshAttrs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export function FreshAttrs(props: FreshAttrs) {
return (
<div id={props.id} class={active.value ? "ready" : ""}>
<h1>Fresh attrs</h1>
<div class="f-client-nav-true" f-client-nav={true}>f-client-nav=true</div>
<div class="f-client-nav-true" f-client-nav>f-client-nav=true</div>
<div class="f-client-nav-false" f-client-nav={false}>
f-client-nav=false
</div>
Expand Down
6 changes: 5 additions & 1 deletion tests/fixtures_islands/IslandInIsland.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@ export function IslandInIsland() {

return (
<div>
<button class="trigger" onClick={() => sig.value = sig.peek() + 1}>
<button
type="button"
class="trigger"
onClick={() => sig.value = sig.peek() + 1}
>
trigger
</button>
<Counter count={sig} />
Expand Down
6 changes: 5 additions & 1 deletion tests/fixtures_islands/JsxConditional.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@ export function JsxConditional(props: JsxConditionalProps) {
return (
<div class={active.value ? "ready" : ""}>
<p class="cond-output">{sig}</p>
<button class="cond-update" onClick={() => sig.value = sig.peek() + 1}>
<button
type="button"
class="cond-update"
onClick={() => sig.value = sig.peek() + 1}
>
update
</button>
<div class="jsx">{active.value ? props.jsx : null}</div>
Expand Down
6 changes: 5 additions & 1 deletion tests/fixtures_islands/JsxIsland.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,11 @@ export function JsxIsland(props: JsxIslandProps) {
return (
<div class={active.value ? "ready" : ""}>
<p class="output">{sig}</p>
<button class="update" onClick={() => sig.value = sig.peek() + 1}>
<button
type="button"
class="update"
onClick={() => sig.value = sig.peek() + 1}
>
update
</button>
<div class="jsx">{props.jsx}</div>
Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures_islands/NodeProcess.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export function NodeProcess() {
}, []);

// @ts-ignore bundling
// deno-lint-ignore no-process-globals
// deno-lint-ignore no-process-global
const value = IS_BROWSER ? process.env.NODE_ENV : "no";

return (
Expand Down
Loading
Loading