Skip to content

refactor(init): avoid network request for downloading of favicon #2867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marvinhagemeister merged 2 commits into from
Apr 28, 2025
Merged

refactor(init): avoid network request for downloading of favicon #2867

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
347751e
refactor(init): skip network request for downloading of favicon
iuioiua Apr 27, 2025
bdf063f
Merge branch 'main' into skip-fetch-init
iuioiua Apr 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions init/src/init.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,14 +391,12 @@ ${GRADIENT_CSS}`;
<path d="M14.297 16.49c.985-.747 1.644-1.01 2.099-2.526.566.121.841-.08 1.29-.701.324.466 1.657.608 2.453.701-.715.451-1.057.852-1.452 2.106-1.464-.611-3.167-.302-4.39.42Z" fill="#fff"/>
</svg>`;
await writeFile("static/logo.svg", STATIC_LOGO);

try {
const res = await fetch("https://fresh.deno.dev/favicon.ico");
const buf = await res.arrayBuffer();
await writeFile("static/favicon.ico", new Uint8Array(buf));
} catch {
// Skip this and be silent if there is a network issue.
}
await writeFile(
"static/favicon.ico",
await Deno.readFile(
new URL(import.meta.resolve("../../www/static/favicon.ico")),
),
);

const MAIN_TS = `import { App, fsRoutes, staticFiles } from "fresh";
import { define, type State } from "./utils.ts";
Expand Down
Loading