Closed
Conversation
Contributor
Author
|
Oh, I see a lot of test errors. It seems the v2 signal version with it's |
Contributor
|
I'd hold off on this PR until #2900 is merged. |
Contributor
Author
|
True, it's probably better to address the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had an issue while using Fresh alpha where I got errors because I was using
v2.0.4of@preact/signals. I had to ensure I was usingv1.x, becausejsr:@fresh/corehad a dependency on the 1.x version. The errors said something about "effect() is already running", when the library was loaded twice, and it was hard to figure out what the root issue was.Is there a way to set a version range with
deno.jsonimports? I could not find support for range (-) or OR (||), that can be done withpackage.json.Is there a reason not to use the
v2version of Signals? If this PR does something dumb, I don't mind it being closed. I was just surprised a newly generated Fresh project had to use the "old" signals major.