refactor(core): replace missingBuildHandler() with throwing of new SetupError#2922
Closed
iuioiua wants to merge 12 commits intodenoland:mainfrom
iuioiua:remove-finish-setup
Closed
refactor(core): replace missingBuildHandler() with throwing of new SetupError#2922iuioiua wants to merge 12 commits intodenoland:mainfrom iuioiua:remove-finish-setup
missingBuildHandler() with throwing of new SetupError#2922iuioiua wants to merge 12 commits intodenoland:mainfrom
iuioiua:remove-finish-setup
Conversation
iuioiua
commented
May 12, 2025
Contributor
Author
There was a problem hiding this comment.
These changes might need to be reverted if checks in App.prototype.handler() are moved to App.prototype.listen().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the behaviour of
App.prototype.handler()in that when run, it throws a newSetupErrorinstead of succeeding and serving a page that guides the dev to finish setting up the server. This provide more immediate feedback.This might be a prerequisite for #2896.