Skip to content

fix: duplicate @preact/signals version #2964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marvinhagemeister merged 3 commits into from
May 16, 2025
Merged

fix: duplicate @preact/signals version #2964

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e31d03
fix: duplicate `@preact/signals` version
marvinhagemeister May 16, 2025
87e8bc7
fix: update www signals version
marvinhagemeister May 16, 2025
fa61643
update www signals
marvinhagemeister May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deno.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"$ga4": "https://raw.githubusercontent.com/denoland/ga4/main/mod.ts",
"@luca/esbuild-deno-loader": "jsr:@luca/esbuild-deno-loader@^0.11.0",
"@opentelemetry/api": "npm:@opentelemetry/api@^1.9.0",
"@preact/signals": "npm:@preact/signals@^1.2.3",
"@preact/signals": "npm:@preact/signals@^2.0.4",
"esbuild": "npm:esbuild@0.23.1",
"esbuild-wasm": "npm:esbuild-wasm@0.23.1",
"@std/crypto": "jsr:@std/crypto@1",
Expand Down
77 changes: 72 additions & 5 deletions deno.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 23 additions & 0 deletions tools/release.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,29 @@ function updateVersions(content: string): string {
return replaced;
}

function replaceDepVersion(
registry: "jsr" | "npm",
name: string,
version: string,
) {
return (content: string) => {
return content.replace(
new RegExp(`"${name}":\\s"[^"]+"`),
`"${name}": "${registry}:${name}@^${version}"`,
);
};
}

// Update preact + @preact/signals version
await replaceInFile(
denoJsonPath,
replaceDepVersion("npm", "preact", preactVersion),
);
await replaceInFile(
denoJsonPath,
replaceDepVersion("npm", "@preact/signals", preactSignalsVersion),
);

const updateScriptPath = path.join(ROOT_DIR, "update", "src", "update.ts");
await replaceInFile(updateScriptPath, updateVersions);

Expand Down
2 changes: 1 addition & 1 deletion www/deno.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"$ga4": "https://raw.githubusercontent.com/denoland/ga4/main/mod.ts",
"@fresh/plugin-tailwind": "../plugin-tailwindcss/src/mod.ts",
"@luca/esbuild-deno-loader": "jsr:@luca/esbuild-deno-loader@^0.11.0",
"@preact/signals": "npm:@preact/signals@^1.3.0",
"@preact/signals": "npm:@preact/signals@^2.0.4",
Copy link
Contributor

@csvn csvn May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not possible to remove this dependency from here instead? Will that not use the same version as the root deno.json instead via workspaces?

Copy link
Contributor Author

@marvinhagemeister marvinhagemeister May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah there is a PR for that #2900 . Was kinda hoping we could have support for workspace:* syntax similar to pnpm in Deno by now, but it looks like that is getting pushed on the back burner.

"@std/crypto": "jsr:@std/crypto@1",
"@std/datetime": "jsr:@std/datetime@0.225.0",
"@std/encoding": "jsr:@std/encoding@1",
Expand Down