[docs]Update Fresh project setup commands and Hero component configuration #3334
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Fresh project initialization command in README files to use 'deno run -Ar jsr:@fresh/init'. Updated Hero component to remove 'origin' prop and use the new command in CopyArea.
Eliminated the unused 'origin' variable from the MainPage component in index.tsx for cleaner code.
Replaced placeholder TODOs with relevant screenshots in the getting started documentation. Added three new images to illustrate app initialization, about page, and countdown example.
|
A bit unsure if we should merge it now or wait until 2.0 is officially released. |
I personally think everyone is eagerly waiting for V2, and the changes you've driven are significant. At least from my perspective, it would be better to let everyone feel (the changes) sooner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates documentation and example code to reflect a new project initialization command and improves developer experience by clarifying the development workflow. It also simplifies the
Herocomponent interface and updates the copy area to use the new init command.Documentation and usage updates:
README.mdand the homepageHerocomponent to usedeno run -Ar jsr:@fresh/initinstead of the previous URL-based command. [1] [2]www/README.mdto usedeno task devinstead ofdeno task start, clarifying the command for starting the development server.Code simplification:
Herocomponent by removing theoriginprop, as it is no longer needed with the static init command.