fix: handle websocket connections using experimental deno:request event #3446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CertainLach
commented
Sep 16, 2025
Comment on lines
+20
to
+24
| if ( | ||
| headers.get("upgrade") !== "websocket" || | ||
| // Vite uses websockets with protocol set to vite-hmr, vite-ping | ||
| headers.get("sec-websocket-protocol")?.startsWith("vite-") | ||
| ) { |
There was a problem hiding this comment.
I wish every non-vite request was going through this route, as the current implementation looks too fragile
It is however only required and used for websocket for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3350
Requires deno with this PR: denoland/deno#30746
Context: