Skip to content

Conversation

fry69
Copy link
Contributor

@fry69 fry69 commented Sep 16, 2025

Reason: Leftover tmp_vite* folders are piling up in my filesystem inside the repository

Copy link
Collaborator

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marvinhagemeister
Copy link
Collaborator

CI says "no" though. Not sure why.

[
  'error: Failed loading https://registry.npmjs.org/fdir for package "fdir"',
  "",
  "Caused by:",
  '    npm package not found in cache: "fdir", --cached-only is specified.'
]

@fry69
Copy link
Contributor Author

fry69 commented Sep 16, 2025

This does not actually work as I thought it would (a recurring theme).

The local folders seem to be necessary also on Linux and on macOS. I am reverting now and looking for a solution to clean the mess up after failed test leave dangling tmp_vite folders around.

@fry69 fry69 marked this pull request as draft September 16, 2025 11:20
@fry69
Copy link
Contributor Author

fry69 commented Sep 17, 2025

I kind of gave up on this, as deno.test.afterAll() seems also not to be doing what I thought it would do. Unsure if that is a bug or intentional. See my attempt here -> main...fry69:fresh:fry69/fix-vite-tmp-folders

My hypothesis is that deno.test.afterAll() does not seem to fire in parallel mode, probably because test fail during setup. But this is just a guess.

FWIW, I leave this PR open for comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants