static files dir is now configurable.#3498
Open
theTechGoose wants to merge 1 commit intodenoland:mainfrom
Open
static files dir is now configurable.#3498theTechGoose wants to merge 1 commit intodenoland:mainfrom
theTechGoose wants to merge 1 commit intodenoland:mainfrom
Conversation
Collaborator
|
The static file directory can already be configured with vite's I'm asking because I don't think the proposed changes here will do anything since the build cache is not aware of the new path. So the changes will likely lead to broken apps if the newly added option is used. |
Author
|
Mmmm yeah that's a way better solution! I didn't have issues with it I just didn't see it as an option. I'm having a heck of a time trying to integrate this with my Deno mono-repo. Are there some docs anywhere about how to make this work across workspace member boundaries?
…--
Raphael Castro
TED Team
Monster Reservations Group
C: 843.855.7133
www.monsterrg.com ( http://www.monsterrg.com/ )
On Fri, Sep 26, 2025 at 2:57 PM, Marvin Hagemeister < ***@***.*** > wrote:
*marvinhagemeister* left a comment (denoland/ fresh#3498) (
#3498 (comment) )
The static file directory can already be configured with vite's publicDir (
https://vite.dev/config/shared-options.html#publicdir ) config. Did you ran
into issues with that?
I'm asking because I don't think the proposed changes here will do
anything since the build cache is not aware of the new path. So the
changes will likely lead to broken apps if the newly added option is used.
—
Reply to this email directly, view it on GitHub (
#3498 (comment) ) , or
unsubscribe (
https://github.com/notifications/unsubscribe-auth/ANK7G7B573DUFXQKGZZPPOT3UWD77AVCNFSM6AAAAACHTS2Y3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGNBQGA3DANRZGI
).
You are receiving this because you authored the thread. Message ID: <denoland/fresh/pull/3498/c3340060692
@ github. com>
|
Collaborator
|
It should work out of the box. It sounds like that's not working for you though and you're running into issues. Would you like to share them with us? Any details you found out help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to be able to configure the static directory for the static files middleware. i'm just replacing /static path in the file with a parameter in the outer function of the closure.