docs: add clarification for assets/static#3525
Open
fry69 wants to merge 5 commits intodenoland:mainfrom
Open
Conversation
Contributor
|
I tried this out based on the issue mentioned in #3482 and it didn't seem to work. A font referenced from a CSS |
Contributor
Author
|
@CAYdenberg This works for me with /* assets/styles.css */
@import "tailwindcss";
@font-face {
font-family: "Roboto";
src: url("/Roboto-Regular.ttf") format("truetype");
font-weight: normal;
font-style: normal;
}
body {
font-family: "Roboto", sans-serif;
}The |
Contributor
|
I think my confusion stems from:
In this case though, the fonts themselves (not the CSS referring to the fonts) should be in static |
Contributor
Author
|
@CAYdenberg Should be fixed now |
Contributor
|
This LGTM (but I'm not a real reviewer). 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a short clarification how imported assets vs. static files get handled now with Vite to the existing documentation for static files.