fix: use consistent u32 type for enum constants on Windows#2
Closed
kajukitli wants to merge 0 commit intodenoland:mainfrom
Closed
fix: use consistent u32 type for enum constants on Windows#2kajukitli wants to merge 0 commit intodenoland:mainfrom
kajukitli wants to merge 0 commit intodenoland:mainfrom
Conversation
1692f44 to
72ea8e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bindgen generates C enums as
i32by default, but on Windows MSVC this can cause type mismatches when consuming code expectsu32constants.Use
EnumVariation::Conststo generate all enum constants asu32for cross-platform consistency.Fixes build errors like:
See failing CI: https://github.com/denoland/deno/actions/runs/22631099295/job/65581121314?pr=32418