fix: ensure consistent enum constant types across platforms#3
Closed
kajukitli wants to merge 1 commit intodenoland:mainfrom
Closed
fix: ensure consistent enum constant types across platforms#3kajukitli wants to merge 1 commit intodenoland:mainfrom
kajukitli wants to merge 1 commit intodenoland:mainfrom
Conversation
bindgen generates C enum constants as i32 on Windows MSVC (C enums are always 'int') but u32 on Linux/macOS. This causes type mismatches when consumers assign these constants to u32 fields. Add .default_enum_style(bindgen::EnumVariation::Consts) and .translate_enum_integer_types(true) to generate consistent u32 types across all platforms.
kajukitli
force-pushed
the
fix-windows-enum-types
branch
from
b785f09 to
220ea06
Compare
littledivy
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows MSVC, C enums are always
int(i32), while on other platforms bindgen may generate them as u32 for non-negative enums. This causes type mismatches when code using the bindings expects u32.Add
.default_enum_style(bindgen::EnumVariation::Consts)and.translate_enum_integer_types(true)to ensure consistent types regardless of platform.Fixes the Windows build errors in denoland/deno#32418