Skip to content

allow V8Inspector::create_stack_trace with empty local #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
littledivy merged 1 commit into from
Jan 29, 2025
Merged

allow V8Inspector::create_stack_trace with empty local #1684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/inspector.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1041,12 +1041,12 @@ impl V8Inspector {

pub fn create_stack_trace(
&mut self,
stack_trace: Local<StackTrace>,
stack_trace: Option<Local<StackTrace>>,
) -> UniquePtr<V8StackTrace> {
unsafe {
UniquePtr::from_raw(v8_inspector__V8Inspector__createStackTrace(
self,
&*stack_trace,
stack_trace.map_or(null(), |v| &*v),
))
}
}
Expand Down
2 changes: 1 addition & 1 deletion tests/test_api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6847,7 +6847,7 @@ fn inspector_exception_thrown() {
v8::String::new(&mut context_scope, "This is a test error").unwrap();
let exception = v8::Exception::error(&mut context_scope, exception_msg);
let stack_trace =
v8::Exception::get_stack_trace(&mut context_scope, exception).unwrap();
v8::Exception::get_stack_trace(&mut context_scope, exception);
let stack_trace_ptr = inspector.create_stack_trace(stack_trace);
let _id = inspector.exception_thrown(
context,
Expand Down
Loading