Conversation
da21edb to
348b8a5
Compare
| unsafe impl Send for IsolateGroup {} | ||
| unsafe impl Sync for IsolateGroup {} | ||
|
|
||
| impl IsolateGroup { |
There was a problem hiding this comment.
It's unfortunate that IsolateGroup currently does not implement Clone.
This is because the C++ class explicitly deletes the copy constructor.
We could probably work around this somehow, although a fairly naive hack that calls internal_isolate_group->Acquire() didn't work when I tried.
|
wow this looks identical to my local changes to this lol. could you update the module_snapshot test to use a new group? that will prevent it from being flakey when run without nextest. |
It doesn't currently build with multiple group support in CI (requires local |
Currently requires the following gn flags to work: ``` v8_enable_external_code_space = true v8_enable_pointer_compression = true v8_enable_pointer_compression_shared_cage = false v8_enable_sandbox = false ```
348b8a5 to
8e11074
Compare
|
Unfortunately, it doesn't seem possible to use isolate groups with pointer compression disabled. |
|
Is there still interest in bringing IsolateGroup support to rusty_v8? If so, I can try to refresh this PR. |
Currently requires the following gn flags to work: