Rolling to V8 13.5.212.1

.gitmodules

@@ -46,3 +46,6 @@
 [submodule "third_party/highway/src"]
 	path = third_party/highway/src
 	url = https://chromium.googlesource.com/external/github.com/google/highway.git
+[submodule "third_party/partition_alloc"]
+	path = third_party/partition_alloc
+	url = https://chromium.googlesource.com/chromium/src/base/allocator/partition_allocator.git

README.md

@@ -1,6 +1,6 @@
 # Rusty V8 Binding
 
-V8 Version: 13.4.114.17
+V8 Version: 13.5.212.0
 
 [![ci](https://github.com/denoland/rusty_v8/workflows/ci/badge.svg?branch=main)](https://github.com/denoland/rusty_v8/actions)
 [![crates](https://img.shields.io/crates/v/v8.svg)](https://crates.io/crates/v8)

src/array_buffer_view.rs

@@ -121,7 +121,12 @@ impl ArrayBufferView {
   {
     unsafe {
       let (data, size) = self.get_contents_raw_parts(storage);
-      std::slice::from_raw_parts(data, size)
+      if data.is_null() {
+        debug_assert_eq!(size, 0);
+        std::slice::from_raw_parts(std::ptr::dangling(), size)
+      } else {
+        std::slice::from_raw_parts(data, size)
+      }
     }
   }
 }

src/binding.cc

@@ -7,6 +7,7 @@
 #include <iostream>
 #include <memory>
 
+#include "cppgc/allocation.h"
 #include "cppgc/platform.h"
 #include "support.h"
 #include "unicode/locid.h"

src/function.rs

@@ -243,7 +243,7 @@ pub struct FunctionCallbackInfo {
 impl FunctionCallbackInfo {
   const kHolderIndex: i32 = 0;
   const kIsolateIndex: i32 = 1;
-  const kUnusedIndex: i32 = 2;
+  const kContextIndex: i32 = 2;
   const kReturnValueIndex: i32 = 3;
   const kTargetIndex: i32 = 4;
   const kNewTargetIndex: i32 = 5;
@@ -263,11 +263,6 @@ impl FunctionCallbackInfo {
     self.get_implicit_arg_non_null::<Value>(Self::kReturnValueIndex)
   }
 
-  #[inline(always)]
-  pub(crate) fn holder(&self) -> Local<Object> {
-    unsafe { self.get_implicit_arg_local(Self::kHolderIndex) }
-  }
-
   #[inline(always)]
   pub(crate) fn new_target(&self) -> Local<Value> {
     unsafe { self.get_implicit_arg_local(Self::kNewTargetIndex) }
@@ -374,19 +369,6 @@ impl<'s> FunctionCallbackArguments<'s> {
     unsafe { &mut *self.0.get_isolate_ptr() }
   }
 
-  /// If the callback was created without a Signature, this is the same value as
-  /// `this()`. If there is a signature, and the signature didn't match `this()`
-  /// but one of its hidden prototypes, this will be the respective hidden
-  /// prototype.
-  ///
-  /// Note that this is not the prototype of `this()` on which the accessor
-  /// referencing this callback was found (which in V8 internally is often
-  /// referred to as holder [sic]).
-  #[inline(always)]
-  pub fn holder(&self) -> Local<'s, Object> {
-    self.0.holder()
-  }
-
   /// For construct calls, this returns the "new.target" value.
   #[inline(always)]
   pub fn new_target(&self) -> Local<'s, Value> {

src/string.rs

@@ -286,6 +286,11 @@ unsafe extern "C" fn one_byte_const_estimate_memory_usage(
 ) -> int {
   -1
 }
+unsafe extern "C" fn one_byte_const_estimate_shared_memory_usage(
+  _this: *const OneByteConst,
+  _recorder: *mut (),
+) {
+}
 
 type OneByteConstNoOp = unsafe extern "C" fn(*const OneByteConst);
 type OneByteConstIsCacheable =
@@ -297,6 +302,8 @@ type OneByteConstUnaccount =
   unsafe extern "C" fn(*const OneByteConst, *mut Isolate);
 type OneByteConstEstimateMemoryUsage =
   unsafe extern "C" fn(*const OneByteConst) -> int;
+type OneByteConstEstimateSharedMemoryUsage =
+  unsafe extern "C" fn(*const OneByteConst, *mut ());
 
 #[repr(C)]
 struct OneByteConstVtable {
@@ -327,6 +334,7 @@ struct OneByteConstVtable {
   is_cacheable: OneByteConstIsCacheable,
   unaccount: OneByteConstUnaccount,
   estimate_memory_usage: OneByteConstEstimateMemoryUsage,
+  estimate_shared_memory_usage: OneByteConstEstimateSharedMemoryUsage,
   dispose: OneByteConstNoOp,
   lock: OneByteConstNoOp,
   unlock: OneByteConstNoOp,
@@ -344,6 +352,7 @@ const ONE_BYTE_CONST_VTABLE: OneByteConstVtable = OneByteConstVtable {
   is_cacheable: one_byte_const_is_cacheable,
   unaccount: one_byte_const_unaccount,
   estimate_memory_usage: one_byte_const_estimate_memory_usage,
+  estimate_shared_memory_usage: one_byte_const_estimate_shared_memory_usage,
   dispose: one_byte_const_no_op,
   lock: one_byte_const_no_op,
   unlock: one_byte_const_no_op,

tests/test_api.rs

@@ -1938,7 +1938,6 @@ fn instance_template_with_internal_field() {
   ) {
     let this = args.this();
 
-    assert_eq!(args.holder(), this);
     assert!(args.data().is_undefined());
 
     assert!(this.set_internal_field(0, v8::Integer::new(scope, 42).into()));
@@ -2135,7 +2134,6 @@ fn object_template_set_accessor() {
     ) {
       let this = args.this();
 
-      assert_eq!(args.holder(), this);
       assert!(args.data().is_undefined());
 
       let ret = v8::Integer::new(scope, 69);