Closed
Conversation
|
|
anonrig
force-pushed
the
yagiz/fix-includes
branch
from
4a25456 to
d9546a0
Compare
Member
|
Does it not build for you without these changes? that'd be strange because it's building in CI. Are you using |
Author
I'm trying to build from a different environment where I'm trying to build rusty_v8 without any build steps, except for linking. I'll open more PRs once I figure out how to avoid copying of the static file in build.rs. But definitely this didn't work for me. |
Member
|
fyi i am fixing all the header usage in #1710 |
Member
|
Thanks - this was included in #1710 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @devsnek @ry