Store IsolateHandle data in its own allocation #1891
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
IsolateHandleis unsound - it mutatesIsolateAnnex.isolatethrough an immutable reference with noUnsafeCell. A much cleaner solution is to store the data forIsolateHandlein its own allocation, since that also means an extantIsolateHandlewon't prevent the other data inIsolateAnnexfrom being deallocated. I originally was going to store the pointer toIsolateHandleInnerin its own isolate data slot, but realized it was also possible to just still store it inIsolateAnnexfor simplicity.