build: fix static_lib_name for non-MSVC Windows toolchains#1957
Open
ognevny wants to merge 1 commit into
Open
Conversation
only MSVC uses such library names, other toolchains (like MinGW) apply lib prefix and use .a extension for static libraries
Member
|
Thanks for the PR, but I'm wary to fix something that is working correctly without associated test or rationale. Can you provide more context on this change? |
Author
|
when we use GCC or Clang even on Windows, they use Linux-like way to name libraries. that includes lib prefix and .a extension for static libraries. also Rust's definition of windows-gnu and windows-gnullvm follow this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
only MSVC uses such library names, other toolchains (like MinGW) apply lib prefix and use .a extension for static libraries