Skip to content

fix: return Value from Function::get_name - #2072

Open
ldm0 wants to merge 2 commits into
denoland:mainfrom
ldm0:get-name-fix
Open

ldm0 wants to merge 2 commits into
denoland:mainfrom
ldm0:get-name-fix

Conversation

@ldm0

@ldm0 ldm0 commented Sep 2, 2026

Copy link
Copy Markdown

Match V8's Function::GetName return type instead of assuming every function name is a String.

https://v8.github.io/api/head/classv8_1_1Function.html#a145a91e74d5adb78c8b710618253b487

Match V8's Function::GetName return type instead of assuming every function name is a String.
@CLAassistant

CLAassistant commented Sep 2, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@bartlomieju

Copy link
Copy Markdown
Member

Please add a test that exercises this change

@ldm0

ldm0 commented Sep 2, 2026

Copy link
Copy Markdown
Author

@bartlomieju test added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants